Skip to content

Conversation

@Devanshukoli
Copy link
Contributor

@Devanshukoli Devanshukoli commented Oct 7, 2023

I have built Simple Pomodoro Timer app using react and million.js.

The issue : #605

Added a file named pomodoro_timer.jsx to packages/kitchen-sink/src/example.

I have also used Million.js in it.

The screenshots :

image

The Demo Video :

https://share.zight.com/KouNw1QP

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Oct 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2023 7:36am
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2023 7:36am

@CLAassistant
Copy link

CLAassistant commented Oct 7, 2023

CLA assistant check
All committers have signed the CLA.

@Devanshukoli
Copy link
Contributor Author

@tobySolutions I have built a very simple pomodoro timer app. Let me know if you have any suggestions?

@tobySolutions
Copy link
Contributor

Good job @Devanshukoli; I'm reviewing it now.

Copy link
Contributor

@tobySolutions tobySolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobySolutions
Copy link
Contributor

Merging this now. Good job.

@tobySolutions tobySolutions merged commit e1bdf49 into aidenybai:main Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants