Skip to content

Conversation

@capsy14
Copy link
Contributor

@capsy14 capsy14 commented Oct 8, 2023

Title: Add GitHub User Search and Enhance User Profile #668

Description:

This PR adds a new feature to the application that allows users to search for GitHub users and view their profiles. Additionally, it enhances the user profile functionality by displaying the user's followers, following, location, and bio.

GitHub User Search:

Added a new search feature that allows users to search for GitHub users by their username.
Implemented the search functionality using the GitHub API.
Display search results with user avatars and usernames.
Clicking on a search result takes the user to the corresponding user's profile page.
User Profile Enhancement:

On the user profile page, added a section to display the user's followers and following counts.
Display the user's location and bio if available in their GitHub profile.
Screenshots:
image
image

Testing:

Performed unit tests for the search functionality.
Manually tested the user profile page to ensure that it displays followers, following, location, and bio correctly.
Thank you :)

Resolves #668

@vercel
Copy link

vercel bot commented Oct 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2023 9:12pm
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2023 9:12pm

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@Timonwa Timonwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @capsy14, thank you for your PR. You didn't implement Milion.js in your project. Also, on page load, your details are being shown by default. Can you clear the default? Or add the query as the input value so the users can know that your username brought out the result.

@capsy14
Copy link
Contributor Author

capsy14 commented Oct 8, 2023

Ok !! let me look into the issue.

@capsy14
Copy link
Contributor Author

capsy14 commented Oct 8, 2023

Kindly review this
Thanks :)

@Timonwa
Copy link
Contributor

Timonwa commented Oct 9, 2023

It's OK now. But can you show an error message when a user searches for a username that doesn't exist? Then, we will merge this.

@capsy14
Copy link
Contributor Author

capsy14 commented Oct 9, 2023

I have added an error message that user is not found if username entered doesn't exist.
@Timonwa Kindly review it.
Thanks :)

@Timonwa
Copy link
Contributor

Timonwa commented Oct 10, 2023

nice @capsy14 👍🏽
This is ready for merge @tobySolutions

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6461745633

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 25.706%

Totals Coverage Status
Change from base Build 6447683379: 0.0%
Covered Lines: 1257
Relevant Lines: 5082

💛 - Coveralls

Copy link
Contributor

@tobySolutions tobySolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @Timonwa.

@tobySolutions
Copy link
Contributor

Good job @capsy14!

@tobySolutions tobySolutions merged commit 17f5358 into aidenybai:main Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Kitchen Sink : Github User Search

5 participants