-
-
Notifications
You must be signed in to change notification settings - Fork 590
Added github user search #706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @capsy14, thank you for your PR. You didn't implement Milion.js in your project. Also, on page load, your details are being shown by default. Can you clear the default? Or add the query as the input value so the users can know that your username brought out the result.
|
Ok !! let me look into the issue. |
|
Kindly review this |
|
It's OK now. But can you show an error message when a user searches for a username that doesn't exist? Then, we will merge this. |
|
I have added an error message that user is not found if username entered doesn't exist. |
|
nice @capsy14 👍🏽 |
Pull Request Test Coverage Report for Build 6461745633
💛 - Coveralls |
tobySolutions
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @Timonwa.
|
Good job @capsy14! |
Title: Add GitHub User Search and Enhance User Profile #668
Description:
This PR adds a new feature to the application that allows users to search for GitHub users and view their profiles. Additionally, it enhances the user profile functionality by displaying the user's followers, following, location, and bio.
GitHub User Search:
Added a new search feature that allows users to search for GitHub users by their username.
Implemented the search functionality using the GitHub API.
Display search results with user avatars and usernames.
Clicking on a search result takes the user to the corresponding user's profile page.
User Profile Enhancement:
On the user profile page, added a section to display the user's followers and following counts.


Display the user's location and bio if available in their GitHub profile.
Screenshots:
Testing:
Performed unit tests for the search functionality.
Manually tested the user profile page to ensure that it displays followers, following, location, and bio correctly.
Thank you :)
Resolves #668