Skip to content

Conversation

@haideralipunjabi
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:

This should fix the immediate issue with the Workflow. Although I suspect there might be another issue which I can only verify after this is merged

Status

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Nov 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2023 4:23pm
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2023 4:23pm

@CLAassistant
Copy link

CLAassistant commented Nov 8, 2023

CLA assistant check
All committers have signed the CLA.

@tobySolutions
Copy link
Contributor

Hmm, thanks @haideralipunjabi. Let me review this

@tobySolutions
Copy link
Contributor

Let's try this too.

@tobySolutions tobySolutions merged commit 289b909 into aidenybai:main Nov 9, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6801073187

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on fix/labeller at 25.706%

Totals Coverage Status
Change from base Build 6800519726: 25.7%
Covered Lines: 1257
Relevant Lines: 5082

💛 - Coveralls

Aslemammad pushed a commit that referenced this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants