fix: unique key error
#946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Pull Request Test Coverage Report for Build 7780067223
💛 - Coveralls |
Aslemammad
reviewed
Feb 6, 2024
| const vnode = createElement(Fragment, {}, marker, createElement(Effect, { | ||
| effect, | ||
| deps: hmrTimestamp ? [hmrTimestamp] : [], | ||
| }), children); |
Collaborator
There was a problem hiding this comment.
is it possible that portals (children) won't have a key and the warning would be shown again?
What I'd suggest is that you spread the children by , ...children, so this way the whole error would be removed.
}), ...children);
Collaborator
Author
There was a problem hiding this comment.
spreading might hit the arguments bound because it has a lower bound than arrays.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the unintentional unique
keyerror thrown by React because ofblock