-
-
Notifications
You must be signed in to change notification settings - Fork 590
fix: gatsby object object #954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this pull request! A maintainer will review it soon.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hmm, nice work @Aslemammad. Thanks for this. Are you giving the user a compiler message so they are aware of that caveat (the .jsx/.tsx) thing or do we need to document that? |
Pull Request Test Coverage Report for Build 7827031851
💛 - Coveralls |
| }; | ||
| ``` | ||
| </Tab> | ||
| <Callout type="warning"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, here it is. My bad
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days. |
Since portals were not being scoped the react element object was rendered as [object object] in the million mounts. I fixed this by returning some code + some modifications.
The other thing this PR does is that it tells folks to have their components in jsx/tsx. since one of the repros I had was using .js (gatsby) and the components were not being optimized.