Skip to content

Conversation

@Aslemammad
Copy link
Collaborator

Since portals were not being scoped the react element object was rendered as [object object] in the million mounts. I fixed this by returning some code + some modifications.

The other thing this PR does is that it tells folks to have their components in jsx/tsx. since one of the repros I had was using .js (gatsby) and the components were not being optimized.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! A maintainer will review it soon.

@vercel
Copy link

vercel bot commented Feb 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2024 4:59am
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2024 4:59am

@tobySolutions
Copy link
Contributor

Since portals were not being scoped the react element object was rendered as [object object] in the million mounts. I fixed this by returning some code + some modifications.

The other thing this PR does is that it tells folks to have their components in jsx/tsx. since one of the repros I had was using .js (gatsby) and the components were not being optimized.

Hmm, nice work @Aslemammad. Thanks for this. Are you giving the user a compiler message so they are aware of that caveat (the .jsx/.tsx) thing or do we need to document that?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7827031851

  • -16 of 16 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 3.617%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-server/index.ts 0 16 0.0%
Totals Coverage Status
Change from base Build 7825819597: 0.0%
Covered Lines: 884
Relevant Lines: 27076

💛 - Coveralls

};
```
</Tab>
<Callout type="warning">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, here it is. My bad

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.

@github-actions github-actions bot added the Stale label Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants