removing old redundant code that yields SettingWithCopyWarning, remove depracated inplace, and fix hanging tests #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekendratimsina
force-pushed
the
fix_redundant_code_that_gives_warning
branch
from
60f5c1c to
c049961
Compare
tekendratimsina
force-pushed
the
fix_redundant_code_that_gives_warning
branch
from
c049961 to
520ca19
Compare
|
@aiguofer Update: I think i manage to fix it on latest commit ! |
tekendratimsina
changed the title
|
awesome, thanks so much for your contribution! Yeah I think removing that fix is probably good, doubt many people are still using a known bad version of pandas... and if so they can upgrade. And thanks for fixing the test! |
|
released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hack, which was created due to the bug during that time, has now been fixed. So i am assuming it is better to remove it rather than fixing code(
util.py:226) that is givingSettingWithCopyWarning. Also,inplaceparameter in pandas.Categorical.add_categories is deprecated and thus removed.Also, some fix on tests !