Skip to content

765 Disable stdout output & tqdm in failing tests #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 47 commits into from
Aug 5, 2022
Merged

Conversation

gkirgizov
Copy link
Collaborator

Fixes #765

@gkirgizov gkirgizov self-assigned this Jul 7, 2022
@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #766 (89e7301) into master (418cd0d) will decrease coverage by 0.09%.
The diff coverage is 78.57%.

@@            Coverage Diff             @@
##           master     #766      +/-   ##
==========================================
- Coverage   87.70%   87.61%   -0.10%     
==========================================
  Files         186      185       -1     
  Lines       12875    12885      +10     
==========================================
- Hits        11292    11289       -3     
- Misses       1583     1596      +13     
Impacted Files Coverage Δ
fedot/api/main.py 79.21% <ø> (ø)
...edot/core/optimisers/gp_comp/operators/mutation.py 93.27% <ø> (+0.44%) ⬆️
fedot/core/optimisers/gp_comp/individual.py 72.34% <33.33%> (ø)
fedot/core/optimisers/populational_optimizer.py 85.71% <36.36%> (-9.21%) ⬇️
fedot/core/optimisers/opt_history.py 75.26% <84.61%> (+0.68%) ⬆️
fedot/core/log.py 87.01% <91.66%> (-6.24%) ⬇️
fedot/api/api_utils/api_composer.py 97.43% <100.00%> (+0.01%) ⬆️
fedot/core/composer/gp_composer/gp_composer.py 95.45% <100.00%> (ø)
...n/operation_implementations/models/custom_model.py 92.50% <100.00%> (+2.25%) ⬆️
fedot/core/operations/operation.py 96.10% <100.00%> (-0.10%) ⬇️
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pep8speaks
Copy link

pep8speaks commented Jul 10, 2022

Hello @gkirgizov! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-08-05 09:05:18 UTC

@gkirgizov gkirgizov force-pushed the fix-765-attempt branch 4 times, most recently from a9a6a42 to 0676f4f Compare July 13, 2022 10:35
@gkirgizov gkirgizov force-pushed the fix-765-attempt branch 4 times, most recently from 28ed93b to 4523d76 Compare July 26, 2022 06:30
@gkirgizov gkirgizov linked an issue Jul 26, 2022 that may be closed by this pull request
3 tasks
@gkirgizov gkirgizov changed the title Fix for 765, remove stdout capture in pytest run 765 Disable stdout output & tqdm in failing tests Jul 26, 2022
@gkirgizov gkirgizov removed their assignment Jul 26, 2022
@maypink maypink force-pushed the fix-765-attempt branch 2 times, most recently from 1149601 to 7f12e11 Compare August 2, 2022 10:32
@gkirgizov gkirgizov force-pushed the fix-765-attempt branch 6 times, most recently from 8a5361f to 8ddb143 Compare August 4, 2022 13:00
@gkirgizov
Copy link
Collaborator Author

The main issue was because of this line: https://github.com/nccr-itmo/FEDOT/blob/7eb49b15c0f614493c5c94f5ac0ca5c6405d15b7/fedot/core/operations/operation.py#L80
in Operation.fit method. Finally, fixed

@MorrisNein MorrisNein self-requested a review August 4, 2022 21:23
@MorrisNein
Copy link
Collaborator

MorrisNein commented Aug 5, 2022

@MorrisNein
Copy link
Collaborator

MorrisNein commented Aug 5, 2022

в рамках этого PR

Конечно, если для этого не понадобится дополнительный рефакторинг

@gkirgizov gkirgizov merged commit 3823cc3 into master Aug 5, 2022
@gkirgizov gkirgizov deleted the fix-765-attempt branch August 5, 2022 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix setting logging_level in Optimiser and LoggingAdapter "ValueError: I/O operation on closed file" in Github test runner
5 participants