Skip to content

[PR #10131/7f92bebb backport][3.12] Bump Python version for benchmarks to 3.13 #10133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Dec 6, 2024

This is a backport of PR #10131 as merged into master (7f92beb).

Python 3.13.1 has been released. As its rare to see performance changes in Python versions after .0, and even more rare to see them after .1 its time to start benchmarking against 3.13.1

python/cpython#106555
python/cpython#106879
python/cpython#106528

Showing some modest gains from the above
Screenshot 2024-12-05 at 6 32 31 PM

@bdraco bdraco enabled auto-merge (squash) December 6, 2024 00:41
Copy link

codecov bot commented Dec 6, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
3468 1 3467 99
View the top 1 failed tests by shortest run time
tests.test_helpers test_when_timeout_smaller_second[pyloop]
Stack Traces | 0.152s run time
loop = <_UnixSelectorEventLoop running=False closed=False debug=False>

    #x1B[0m#x1B[94mdef#x1B[39;49;00m #x1B[92mtest_when_timeout_smaller_second#x1B[39;49;00m(loop) -> #x1B[94mNone#x1B[39;49;00m:#x1B[90m#x1B[39;49;00m
        timeout = #x1B[94m0.1#x1B[39;49;00m#x1B[90m#x1B[39;49;00m
        timer = loop.time() + timeout#x1B[90m#x1B[39;49;00m
    #x1B[90m#x1B[39;49;00m
        handle = helpers.TimeoutHandle(loop, timeout)#x1B[90m#x1B[39;49;00m
        when = handle.start()._when#x1B[90m#x1B[39;49;00m
        handle.close()#x1B[90m#x1B[39;49;00m
    #x1B[90m#x1B[39;49;00m
        #x1B[94massert#x1B[39;49;00m #x1B[96misinstance#x1B[39;49;00m(when, #x1B[96mfloat#x1B[39;49;00m)#x1B[90m#x1B[39;49;00m
>       #x1B[94massert#x1B[39;49;00m when - timer == pytest.approx(#x1B[94m0#x1B[39;49;00m, #x1B[96mabs#x1B[39;49;00m=#x1B[94m0.001#x1B[39;49;00m)#x1B[90m#x1B[39;49;00m
#x1B[1m#x1B[31mE       assert 0.001664725000011913 == 0 ± 1.0e-03#x1B[0m
#x1B[1m#x1B[31mE         #x1B[0m
#x1B[1m#x1B[31mE         comparison failed#x1B[0m
#x1B[1m#x1B[31mE         Obtained: 0.001664725000011913#x1B[0m
#x1B[1m#x1B[31mE         Expected: 0 ± 1.0e-03#x1B[0m

handle     = <aiohttp.helpers.TimeoutHandle object at 0x7f4ddf3a80c0>
loop       = <_UnixSelectorEventLoop running=False closed=False debug=False>
timeout    = 0.1
timer      = 231.83015828999999
when       = 231.831823015

#x1B[1m#x1B[31mtests/test_helpers.py#x1B[0m:285: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Copy link

codspeed-hq bot commented Dec 6, 2024

CodSpeed Performance Report

Merging #10133 will improve performances by 12.89%

Comparing patchback/backports/3.12/7f92bebb29d679fd00cae79dff642b18d9b98cda/pr-10131 (46d9d52) with 3.12 (0d886aa)

Summary

⚡ 1 improvements
✅ 46 untouched benchmarks

Benchmarks breakdown

Benchmark 3.12 patchback/backports/3.12/7f92bebb29d679fd00cae79dff642b18d9b98cda/pr-10131 Change
test_simple_web_stream_response 277.3 µs 245.6 µs +12.89%

@bdraco bdraco merged commit 0e4a0e4 into 3.12 Dec 6, 2024
35 checks passed
@bdraco bdraco deleted the patchback/backports/3.12/7f92bebb29d679fd00cae79dff642b18d9b98cda/pr-10131 branch December 6, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant