Skip to content

Conversation

@patchback
Copy link
Contributor

@patchback patchback bot commented Dec 6, 2024

This is a backport of PR #10131 as merged into master (7f92beb).

Python 3.13.1 has been released. As its rare to see performance changes in Python versions after .0, and even more rare to see them after .1 its time to start benchmarking against 3.13.1

python/cpython#106555
python/cpython#106879
python/cpython#106528

Showing some modest gains from the above
Screenshot 2024-12-05 at 6 32 31 PM

@bdraco bdraco enabled auto-merge (squash) December 6, 2024 00:41
@codecov
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.94%. Comparing base (d9b434c) to head (eda6d46).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.10   #10134   +/-   ##
=======================================
  Coverage   97.94%   97.94%           
=======================================
  Files         116      116           
  Lines       36238    36238           
  Branches     4389     4389           
=======================================
  Hits        35494    35494           
  Misses        552      552           
  Partials      192      192           
Flag Coverage Δ
CI-GHA 97.84% <ø> (ø)
OS-Linux 97.54% <ø> (+<0.01%) ⬆️
OS-Windows 95.17% <ø> (ø)
OS-macOS 97.25% <ø> (+<0.01%) ⬆️
Py-3.10.11 97.11% <ø> (+<0.01%) ⬆️
Py-3.10.15 97.09% <ø> (ø)
Py-3.11.10 97.11% <ø> (ø)
Py-3.11.9 97.18% <ø> (+0.01%) ⬆️
Py-3.12.7 97.60% <ø> (-0.01%) ⬇️
Py-3.13.0 97.03% <ø> (-0.53%) ⬇️
Py-3.13.1 97.57% <ø> (?)
Py-3.8.10 94.57% <ø> (ø)
Py-3.8.18 96.89% <ø> (ø)
Py-3.9.13 97.02% <ø> (ø)
Py-3.9.20 96.96% <ø> (-0.04%) ⬇️
Py-pypy7.3.16 96.56% <ø> (-0.01%) ⬇️
VM-macos 97.25% <ø> (+<0.01%) ⬆️
VM-ubuntu 97.54% <ø> (+<0.01%) ⬆️
VM-windows 95.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 6, 2024

CodSpeed Performance Report

Merging #10134 will degrade performances by 74.63%

Comparing patchback/backports/3.10/7f92bebb29d679fd00cae79dff642b18d9b98cda/pr-10131 (eda6d46) with 3.10 (d9b434c)

Summary

❌ 18 regressions
✅ 26 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark 3.10 patchback/backports/3.10/7f92bebb29d679fd00cae79dff642b18d9b98cda/pr-10131 Change
test_one_hundred_get_requests_with_1024_chunked_payload[pyloop] 43.8 ms 57 ms -23.11%
test_one_hundred_get_requests_with_1024_content_length_payload[pyloop] 43.6 ms 57.5 ms -24.08%
test_one_hundred_get_requests_with_30000_chunked_payload[pyloop] 52.9 ms 66.1 ms -19.88%
test_one_hundred_get_requests_with_30000_content_length_payload[pyloop] 47.5 ms 61.4 ms -22.62%
test_one_hundred_simple_get_requests[pyloop] 40.8 ms 53.1 ms -23.11%
test_one_hundred_simple_get_requests_multiple_methods_route[pyloop] 41.1 ms 53.4 ms -22.95%
test_one_hundred_simple_post_requests[pyloop] 44.4 ms 61.7 ms -28.11%
test_client_request_update_cookies[pyloop] 176.2 µs 201.1 µs -12.38%
test_create_client_request_with_cookies[pyloop] 136.6 µs 177.8 µs -23.14%
test_create_client_request_with_headers[pyloop] 74.8 µs 120.3 µs -37.85%
test_send_client_request_one_hundred[pyloop] 4.2 ms 5.3 ms -20.29%
test_serialize_headers 1 ms 2.4 ms -58.46%
test_ten_web_middlewares[pyloop] 43.8 ms 56 ms -21.71%
test_simple_web_response 625.3 µs 1,805.1 µs -65.36%
test_simple_web_stream_response 383.9 µs 817.2 µs -53.03%
test_web_response_with_bytes_body 719.6 µs 1,894.4 µs -62.01%
test_web_response_with_headers 1.2 ms 4.6 ms -74.63%
test_web_response_with_text_body 849.4 µs 2,756.9 µs -69.19%

@bdraco
Copy link
Member

bdraco commented Dec 6, 2024

The problem is there are no multidict binary wheels for the version used in 3.10 so its much much slower

@bdraco
Copy link
Member

bdraco commented Dec 6, 2024

3.10 is likely to never get another version published so there is no need to backport this.

Closing this PR

@bdraco bdraco closed this Dec 6, 2024
auto-merge was automatically disabled December 6, 2024 03:58

Pull request was closed

@bdraco bdraco deleted the patchback/backports/3.10/7f92bebb29d679fd00cae79dff642b18d9b98cda/pr-10131 branch December 6, 2024 03:58
@Dreamsorcerer
Copy link
Member

We've already had several patch releases for 3.11, so let's remove the 3.10 label now..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants