Add output_size property#12452
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #12452 +/- ##
========================================
Coverage 98.94% 98.95%
========================================
Files 131 131
Lines 46475 46620 +145
Branches 2410 2418 +8
========================================
+ Hits 45987 46132 +145
Misses 366 366
Partials 122 122
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Merging this PR will not alter performance
Comparing Footnotes
|
|
Thanks @Dreamsorcerer nice addition |
Backport to 3.14: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 37cd4a8 on top of patchback/backports/3.14/37cd4a8edcbfe543067a96e36f4da3e9395328a3/pr-12452 Backporting merged PR #12452 into master
🤖 @patchback |
| @@ -0,0 +1,2 @@ | |||
| Added :attr:`~aiohttp.ClientResponse.output_size` and | |||
There was a problem hiding this comment.
@Dreamsorcerer FYI this is rendered as just output_size so maybe for such cases we could either drop that leading ~ or use custom text like ClientResponse.output_size().
There was a problem hiding this comment.
I'd really like to stop using these directives in the change fragments entirely... In the GH changelog (which is probably more frequently looked at than the Sphinx ones), this just looks incredibly awkward. It also increases the maintenance burden because we keep needing to remove these directives from the changelog when we remove/rename something in a future version.
|
|
||
| Use ``await resp.upload_complete`` to block until the upload finishes, or | ||
| ``resp.upload_complete.done()`` to poll from a progress-sampling loop | ||
| (see :attr:`output_size`). |
There was a problem hiding this comment.
@Dreamsorcerer FYI the .. seealso:: directive could be a good fit for this.
Can be used to query upload progress.