Consolidate strict rule definition between airbnb and airbnb-base
#1962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables the `strict` rule in 'safe' mode: https://eslint.org/docs/rules/strict#safe
Previously `rules/strict.js` was only used by `eslint-config-airbnb` and not base. This change reduces the duplication, and means the rule is now set to 'never' as opposed to the ESLint default of 'safe'. For users that left the `sourceType` at this preset's default of `module` this change will be a no-op, since in module-mode the `strict` rule always behaves as though 'never' had been set. See: https://eslint.org/docs/rules/strict#options
Since the file is now imported in base instead. Fixes airbnb#1582.
edmorley
force-pushed
the
cleanup-strict-rule
branch
from
ab2bf0b to
b24ffd5
Compare
ljharb
requested changes
Nov 22, 2018
edmorley
force-pushed
the
cleanup-strict-rule
branch
from
b24ffd5 to
fee92ba
Compare
|
I've rebased on master to resolve the conflicts, given the next major release is likely to be not too far out :-) |
ljharb
force-pushed
the
cleanup-strict-rule
branch
from
fee92ba to
ad0c44c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commit messages for more details.
Fixes #1582.