-
Notifications
You must be signed in to change notification settings - Fork 26.7k
📝 [REPO]: Added CONTRIBUTING.md with contribution guidelines to the r… #2279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
rohitjethoe
wants to merge
1
commit into
airbnb:master
Choose a base branch
from
rohitjethoe:repo/contributing.md
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+100
−0
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,100 @@ | ||
# Contributing Guidelines | ||
|
||
### Welcome to airbnb/javascript! | ||
|
||
First off, thank you for considering contributing to Airbnb JavaScript Style Guide. It's people like you that make airbnb/javascript such a great tool. | ||
|
||
Following these guidelines helps to communicate that you respect the time of the developers managing and developing this open source project. In return, they should reciprocate that respect in addressing your issue, assessing changes, and helping you finalize your pull requests. | ||
|
||
### Bug reports | ||
|
||
A bug is a demonstrable problem that is caused by the code in the reposityory. Good bug reports are extremely helpful - thank you! | ||
|
||
Guidelines for bug reports: | ||
|
||
1. **Use the GitHub issue search** — check if the issue has already been reported. | ||
|
||
2. **Check if the issue has been fixed** — try to reproduce it using the latest `master` or `next` branch in the repository. | ||
|
||
3. **Isolate the problem** — ideally create a reduced test case. | ||
|
||
A good bug report shouldn't leave others needing to chase you up for more information. Please try to be as detailed as possible in your report. What is your environment? What steps will reproduce the issue? What OS experiences the problem? What would you expect to be the outcome? All these details will help people to fix any potential bugs. | ||
|
||
Example: | ||
|
||
|
||
> Short and descriptive example bug report title | ||
> | ||
> A summary of the issue and the browser/OS environment in which it occurs. If | ||
> suitable, include the steps required to reproduce the bug. | ||
> | ||
> 1. This is the first step | ||
> 2. This is the second step | ||
> 3. Further steps, etc. | ||
> | ||
> `<url>` - a link to the reduced test case | ||
> | ||
> Any other information you want to share that is relevant to the issue being | ||
> reported. This might include the lines of code that you have identified as | ||
> causing the bug, and potential solutions (and your opinions on their | ||
> merits). | ||
|
||
### Pull requests | ||
|
||
Good pull requests - patches, improvements, new features - are a fantastic | ||
help. They should remain focused in scope and avoid containing unrelated | ||
commits. | ||
|
||
**Please ask first** before embarking on any significant pull request (e.g. | ||
implementing features, refactoring code), otherwise you risk spending a lot of | ||
time working on something that the project's developers might not want to merge | ||
into the project. | ||
|
||
#### For new Contributors | ||
|
||
If you never created a pull request before, welcome 🎉 😄 [Here](https://egghead.io/series/how-to-contribute-to-an-open-source-project-on-github) is a great tutorial on how to send one :) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. videos aren't all that accessible, and this particular site/content is used as an enticement to sell access to further videos - can we find different content to link to? |
||
|
||
1. [Fork](http://help.github.com/fork-a-repo/) the project, clone your fork, | ||
and configure the remotes: | ||
|
||
```bash | ||
# Clone your fork of the repo into the current directory | ||
git clone https://github.com/<your-username>/<repo-name> | ||
# Navigate to the newly cloned directory | ||
cd <repo-name> | ||
# Assign the original repo to a remote called "upstream" | ||
git remote add upstream https://github.com/airbnb/<repo-name> | ||
``` | ||
|
||
2. If you cloned a while ago, get the latest changes from upstream: | ||
|
||
```bash | ||
git checkout master | ||
git pull upstream master | ||
``` | ||
|
||
3. Create a new topic branch (off the main project development branch) to | ||
contain your feature, change, or fix: | ||
|
||
```bash | ||
git checkout -b <topic-branch-name> | ||
``` | ||
|
||
4. Make sure to update, or add to the tests when appropriate. Patches and | ||
features will not be accepted without tests. Run `npm test` to check that | ||
all tests pass after you've made changes. Look for a `Testing` section in | ||
the project’s README for more information. | ||
|
||
5. If you added or changed a feature, make sure to document it accordingly in | ||
the `README.md` file. | ||
|
||
6. Push your topic branch up to your fork: | ||
|
||
```bash | ||
git push origin <topic-branch-name> | ||
``` | ||
|
||
8. [Open a Pull Request](https://help.github.com/articles/using-pull-requests/) | ||
with a clear title and description. | ||
|
||
Thanks! :heart: :heart: :heart: |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good advice for projects in general, but in this project, pretty much the only changes that are expected/welcome from non-maintainers are:
In particular, it should be noted that no "normative" (ie, things that alter the spirit of how you're recommended to write code) guide or eslint config changes will be made unless it's initiated by current Airbnb employees, so it's not a good use of time to propose any.