Set rheostat-disabled css class if slider is disabled
#144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Mar 2, 2018
src/Slider.jsx
Outdated
| classNames.push(props.orientation === 'vertical' | ||
| ? 'rheostat-vertical' | ||
| : 'rheostat-horizontal'; | ||
| : 'rheostat-horizontal'); |
Collaborator
There was a problem hiding this comment.
the ); needs to be on a line by itself; perhaps a cleaner option is classNames.push(orientation), or const classNames = ['rheostat', orientation] after the ternary?
src/Slider.jsx
Outdated
|
|
||
| return ['rheostat', orientation].concat(props.className.split(' ')).join(' '); | ||
| if (props.className) { | ||
| classNames = [...classNames, ...props.className.split(' ')]; |
Collaborator
There was a problem hiding this comment.
classNames.push(...props.className.split(' ')), but this should probably be using the cx package instead of manually splitting :-/
ljharb
reviewed
Mar 7, 2018
| } | ||
|
|
||
| if (props.className) { | ||
| classNames.push(...props.className.split(' ')); |
Collaborator
There was a problem hiding this comment.
I still think this should use the cx package instead of split.
Author
There was a problem hiding this comment.
I haven't introduced manual splitting, it had been there before. Probably it's worth doing that but looks like it's out of scope of this pr.
ljharb
approved these changes
Mar 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be convenient to have
rheostat-disabledin case of slider is disabled. It gives ability to specify css rules to distinguish active and disabled states.