Add RTL support #235
Merged
Add RTL support #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 30, 2019 09:43
- Add react-with-directions to detect RTL/LTR - Change how styles are passed to default child components e.g. DefaultHandle, DefaultProgressBar so they're properly RLT/LTR-ified - Change how handle position is calculated based on direction
ljharb
requested changes
Aug 1, 2019
Collaborator
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
Thanks, this is a great addition!
majapw
reviewed
Aug 1, 2019
src/Slider.jsx
Outdated
| } | ||
| return ((x - sliderBox.left) / sliderBox.width) * PERCENT_FULL; | ||
| if (direction === DIRECTIONS.RTL) { | ||
| return 100 - (((x - sliderBox.left) / sliderBox.width) * PERCENT_FULL); |
Collaborator
There was a problem hiding this comment.
Can we pull the ((x - sliderBox.left) / sliderBox.width) * PERCENT_FULL out into its own variable?
majapw
approved these changes
Aug 1, 2019
Collaborator
majapw
left a comment
majapw
left a comment
There was a problem hiding this comment.
Looks great, one small nit!
ljharb
reviewed
Aug 1, 2019
stories/ExampleSlider.jsx
Outdated
| }) | ||
| .add('RTL Custom Handle', () => { | ||
| function MyHandle({ | ||
| styles, css, style, handleRef, ...passProps |
Collaborator
There was a problem hiding this comment.
all these object keys should be in their own line, since the entire literal doesn’t fit on its own line.
ljharb
approved these changes
Aug 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-with-directionto detect RTL/LTRe.g.
DefaultHandle,DefaultProgressBarso they're properlyRLT/LTR-ified
Also added new storybook examples, some tests, and a note in the docs.