Skip to content

test suite failure with go 1.17 #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 23, 2021
Merged

test suite failure with go 1.17 #37

merged 3 commits into from
Sep 23, 2021

Conversation

tbonfort
Copy link
Member

@tbonfort tbonfort commented Sep 15, 2021 •
edited
Loading

test suite deadlocks on go 1.17

@tbonfort tbonfort changed the title test with go 1.17 runtime failure with go 1.17 Sep 15, 2021
@tbonfort tbonfort marked this pull request as draft September 15, 2021 13:18
@tbonfort
Copy link
Member Author

tbonfort commented Sep 15, 2021 •
edited
Loading

upstream golang issue: golang/go#48402
UPDATE: This is not a golang issue

@tbonfort tbonfort changed the title runtime failure with go 1.17 test suite failure with go 1.17 Sep 15, 2021
@coveralls
Copy link
Collaborator

coveralls commented Sep 23, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1265429107

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.003%) to 99.596%
Files with Coverage Reduction New Missed Lines %
godal.go 10 99.46%
Totals Coverage Status
Change from base Build 1101096851: 0.003%
Covered Lines: 2468
Relevant Lines: 2478
💛 - Coveralls

@tbonfort tbonfort marked this pull request as ready for review September 23, 2021 10:37
@tbonfort tbonfort merged commit c37cc5e into main Sep 23, 2021
@tbonfort tbonfort deleted the go117 branch September 23, 2021 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbonfort @coveralls