CAR-943 Crash in Eastwood and Chios - websocketpp::transport::asio::connection::handle_async_shutdown_timeout #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: examples/scratch_client/SConscript
Conflicts: test/extension/permessage_deflate.cpp websocketpp/extensions/permessage_deflate/disabled.hpp websocketpp/extensions/permessage_deflate/enabled.hpp websocketpp/impl/connection_impl.hpp websocketpp/message_buffer/message.hpp websocketpp/processors/hybi13.hpp
Conflicts: changelog.md
…eferences zaphoyd#459 particularly affected TLS servers and connection close behavior
…vice before it is deleted
This was missing but it is described in the RFC here https://tools.ietf.org/html/draft-ietf-hybi-thewebsocketprotocol-00#section-1.9
…when passing a short address.
Fixed uri validator by checking its length.
…col-support added subprotocol support for hybi00 / hixie76
…t. references zaphoyd#490 zaphoyd#525 There isn't a clean way to implement this performance optimization without adding global state/locking, which performs worse. This should fix
jim-wong
reviewed
Feb 27, 2018
| if (socket_con_type::get_raw_socket().is_open()) { | ||
| socket_con_type::cancel_socket(); | ||
| } | ||
| // airtime: end |
There was a problem hiding this comment.
Do you think this is a fix that we should submit upstream?
…_Crash_in_websocket_pp_async_shutdown_timeout Conflicts: websocketpp/logger/basic.hpp websocketpp/logger/syslog.hpp websocketpp/roles/server_endpoint.hpp websocketpp/transport/asio/connection.hpp websocketpp/transport/asio/endpoint.hpp
artasano
force-pushed
the
feature/CAR-943___Crash_in_websocket_pp_async_shutdown_timeout
branch
from
3684eed to
57d652e
Compare
|
@jim-wong Merged the upstream. |
jim-wong
approved these changes
Feb 28, 2018
artasano
deleted the
feature/CAR-943___Crash_in_websocket_pp_async_shutdown_timeout
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://airtime.atlassian.net/browse/CAR-943