bugfix: race among _connecting and cluster metadata (#2189) #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanyu
approved these changes
Jan 18, 2021
ivanyu
approved these changes
Jan 18, 2021
A call to `maybe_connect` can be performed while the cluster metadata is being updated. If that happens, the assumption that every entry in `_connecting` has metadata won't hold. The existing assert will then raise on every subsequent call to `poll` driving the client instance unusable. This fixes the issue by ignoring connetion request to nodes that do not have the metadata available anymore.
hackaugusto
force-pushed
the
hacka/fix-broker-id-metadata-assert
branch
from
f267998 to
8006e65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of dpkp#2189
A call to
maybe_connectcan be performed while the cluster metadata isbeing updated. If that happens, the assumption that every entry in
_connectinghas metadata won't hold. The existing assert will thenraise on every subsequent call to
polldriving the client instanceunusable.
This fixes the issue by ignoring connetion request to nodes that do not
have the metadata available anymore.