fix: coerce whitespace strings correctly#2297
Open
vwong wants to merge 2 commits intoajv-validator:masterfrom
Open
fix: coerce whitespace strings correctly#2297vwong wants to merge 2 commits intoajv-validator:masterfrom
vwong wants to merge 2 commits intoajv-validator:masterfrom
Conversation
Author
|
The CI is broken, but I'm not sure what I would've done to cause it to break. Help? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue does this pull request resolve?
Number/Integer strings with only whitespace gets coerced to
0, when it should beundefinedWhat changes did you make?
The code already skips coercion on empty zero-length strings, I refined this to skip coercion on strings that are empty after
.trim().Is there anything that requires more attention while reviewing?
No