TIP-747: upgrade the PIM from sf 2.8 to 3 by anaelChardan · Pull Request #6374 · akeneo/pim-community-dev

anaelChardan · 2017-07-02T09:15:07Z

Upgrade the PIM to Symfony 3.3.6 and related dependencies too.
Main changes:

Yaml component is more strict now:
- if a parameter is not surrounded by quote, it send a deprecated alert
- some caracteres have to be protected by quote, like !=, >, >=
Form component change the way they build options. Before, the id of an option was the key and the label was the value. Now it's the reverse \o/
SerializerAwareNormalizer is now deprecated. We have to use the SerializerAwareTrait

Result of bench for medium catalog:

master - symfony 2.8

import 50000 new products: 51:05,68 total
export 50000 products: 11:25,21 total

master - symfony 3.3

import 50000 new products: 52:47,27 total
export 50000 products: 11:44,14 total

Description (for Contributor and Core Developer)

Definition Of Done (for Core Developer only)

Q	A
Added Specs	Todo
Added Behats	Todo
Added integration tests	Todo
Changelog updated	Todo
Review and 2 GTM	Todo
Micro Demo to the PO (Story only)	Todo
Migration script	-
Tech Doc	-

Todo: Pending / Work in progress
OK: Done / Validated
-: Not needed

skeleton · 2017-07-02T18:55:36Z

        "symfony/monolog-bundle": "2.12.1",
        "symfony/swiftmailer-bundle": "2.4.2",
-        "symfony/symfony": "~2.8",
+        "symfony/symfony": "3.3.0",


skeleton · 2017-07-03T10:05:19Z

        "symfony/swiftmailer-bundle": "2.4.2",
-        "symfony/symfony": "~2.8",
+        "symfony/security-acl": "3.0.0",
+        "symfony/symfony": "~3.2.0",


nope, don't do that on require packages, we already done that by the past, and it's a nightmare when there are new minors versions, it can cause regression and are very hard to detect.
So fix it to 3.2.2 please :)

ahocquard · 2017-08-01T19:49:02Z

+    /**
+     * @return string
+     */
+    public function getRootDir()


string return

ahocquard · 2017-08-01T19:49:12Z

+    /**
+     * @return string
+     */
+    public function getCacheDir()


string return

ahocquard · 2017-08-01T19:49:21Z

+    /**
+     * @return string
+     */
+    public function getLogDir()


string return

ahocquard · 2017-08-01T20:05:04Z

+use Symfony\Component\Console\Input\ArgvInput;
+use Symfony\Component\Debug\Debug;
+
+// if you don't want to setup permissions the proper way, just uncomment the following P    HP line


spaces P HP

ahocquard · 2017-08-01T20:31:51Z

-// if you don't want to setup permissions the proper way, just uncomment the following PHP line
+use Symfony\Bundle\FrameworkBundle\Console\Application;
+use Symfony\Component\Console\Input\ArgvInput;
+use Symfony\Component\Debug\Debug;


weird to you use autoloading file after those use statements. Actually I didn't know that it could work. In the example on internet, it's often after.

ahocquard · 2017-08-01T21:09:10Z

    public static function getAllLabels()
    {
-        return self::$statusLabels;
+        return array_flip(self::$statusLabels);


Why ? In the PR, a lot of keys/value are inverted and I don't understand why.

Symfony changed the way the options are built, labels are keys now :(

I do not understand why they did that but anyway...

me too.. does not seem logical, and more important, you can loose data if label is the same :(

ahocquard · 2017-08-01T21:17:10Z

        $choices = [];
        foreach ($channels as $channel) {
-            $choices[$channel['code']] = null !== $channel['label'] ? $channel['label'] : '[' . $channel['code'] . ']';
+            $choices[null !== $channel['label'] ? $channel['label'] : '[' . $channel['code'] . ']'] = $channel['code'];


wooo ternary party 💃

ahocquard · 2017-08-01T21:18:57Z


    /**
-     * @param Request $request
+     * @return Request


null|Request

ahocquard · 2017-08-01T21:21:04Z

            _renderCriteria: function(el) {
+                const inKey = __('pim.grid.choice_filter.label_in_list');
+                const emptyKey = __('pim.grid.choice_filter.label_empty');
+                const notEmptyKey = __('pim.grid.choice_filter.label_not_empty');


just for my personal JS culture, why ?

ask to @anaelChardan ^^

Answered to @momoss in DM.

It was because I thought I should inverts also in JS and in JS we can't build dynamically a JSON key. But it does not seems useful now.

ahocquard · 2017-08-01T21:26:10Z

-require_once __DIR__.'/../app/AppKernel.php';
-//require_once __DIR__.'/../app/AppCache.php';
-
+require __DIR__.'/../vendor/autoload.php';


the web app in prod is the only file in Symfony 3.3 that should load bootstrap.php.cache.

this file has been copied directly from a sf 3.3 fresh installation. They load bootstratp.php.cache file only if the version of PHP is < 7. see https://github.com/symfony/symfony-demo/blob/master/web/app.php#L22

Yes, but this is a demo not focus on performance.
https://symfony.com/doc/current/performance.html#use-bootstrap-files

If we don't provide it in pim-community-dev, no problem, but we should at least put it in the standard edition.

Ok sry I'm wrong:

symfony/symfony-docs#7357
symfony/symfony-standard#1030

I've seen the opposite on some blogs.

…fony

…trait

anaelChardan force-pushed the symfony-upgrade branch from e2fca60 to 7713424 Compare July 2, 2017 09:18

skeleton reviewed Jul 2, 2017

View reviewed changes

anaelChardan force-pushed the symfony-upgrade branch 2 times, most recently from f7d21f9 to 6612a97 Compare July 3, 2017 09:16

skeleton reviewed Jul 3, 2017

View reviewed changes

anaelChardan force-pushed the symfony-upgrade branch 6 times, most recently from 3518c81 to 9e211b1 Compare July 13, 2017 08:03

anaelChardan force-pushed the symfony-upgrade branch 2 times, most recently from 8f8aea6 to 65cb3e6 Compare July 17, 2017 17:37

skeleton force-pushed the symfony-upgrade branch 6 times, most recently from 1ac5fba to 1d15b53 Compare July 25, 2017 13:23

skeleton force-pushed the symfony-upgrade branch 8 times, most recently from c6a94da to 174904c Compare August 1, 2017 19:30

skeleton changed the title ~~TIP-747: Update libraries~~ TIP-747: upgrade the PIM from sf 2.8 to 3 Aug 1, 2017

skeleton force-pushed the symfony-upgrade branch from 174904c to e1f2460 Compare August 1, 2017 19:33

ahocquard reviewed Aug 1, 2017

View reviewed changes

anaelChardan and others added 25 commits August 3, 2017 13:52

TIP-747: Fix Tests

fd87f9e

TIP-747: fix association type

8fc3d21

TIP-747: fix form type in import/export

e3dffde

TIP-747: reverse label/code for form type

b8df6ef

TIP-747: fix user form type

72f6436

TIP-747: fix variant group form type

11f1f58

TIP-747: fix comment form type

e977d1d

TIP-747: fix acl form type

4a82bc2

TIP-747: fix deprecated options

7e0c0b7

TIP-747: remove the useless clear of the unit of work

4b87db7

TIP-747: call doctrine ClassUtils instead of deprecated method in Sym…

64919f8

…fony

TIP-747: change namespace to remove deprecated ValidatorInterface

9fbdfe8

TIP-747: add explicite json format for route

b70f25b

TIP-747: add logs dir in command launcher

5d85588

TIP-747: update Symfony from 3.2 to 3.3

65617ff

TIP-747: fix configuration of extension

ba9d2d7

TIP-747: use Sf 3.3 front controllers

40db29b

TIP-747: remove deprecated call

89a98e4

TIP-747: remove call of deprecated SerializerAwareNormalizer and use …

2b1e0ef

…trait

TIP-747: implode locales as ArrayInput allows only a string

066a642

TIP-747: add BC break because of the migration

7976040

TIP-747: upgrade dependencies

35053fb

TIP-747: use symfony normalizer instead of JMS

5e0180a

TIP-747: configure php-cs-fixer to avoid alignement on multiline

24d9169

TIP-747: fix php-cs-fixer

2fdba4e

skeleton force-pushed the symfony-upgrade branch from 70f3e83 to 2fdba4e Compare August 3, 2017 11:52

ahocquard approved these changes Aug 3, 2017

View reviewed changes

skeleton merged commit 3015ac1 into master Aug 3, 2017

skeleton deleted the symfony-upgrade branch August 3, 2017 17:31

mmetayer mentioned this pull request May 29, 2018

Fix UserContext::toArray() method #8207

Closed

Conversation

anaelChardan commented Jul 2, 2017 • edited by skeleton Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

master - symfony 2.8

master - symfony 3.3

Uh oh!

Choose a reason for hiding this comment

Uh oh!

skeleton Jul 3, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ahocquard Aug 1, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ahocquard Aug 1, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ahocquard Aug 2, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ahocquard Aug 2, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

anaelChardan commented Jul 2, 2017 •

edited by skeleton

Loading

skeleton Jul 3, 2017 •

edited

Loading

ahocquard Aug 1, 2017 •

edited

Loading

ahocquard Aug 1, 2017 •

edited

Loading

ahocquard Aug 2, 2017 •

edited

Loading

ahocquard Aug 2, 2017 •

edited

Loading