Skip to content

Conversation

@LaurenceWarne
Copy link
Contributor

Hi! I think this package is really neat. I've put together this PR which changes string-inflection-skip-backward-when-done to be defined via defcustom.

I've also changed some of the wording in the README so it's closer to English language norms - I hope this is useful and not too intrusive 🙂

README.org Outdated

The =string-inflection-all-cycle=, conversion often. However,
conversion occurs even when there is no need to lower-camelcase.
Therefore so difficult to use, is not recommended
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment still accurate after 4df4b62?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accurate.
I still do not use string-infection-all-cycle.
It is better to use the appropriate function to match the emacs major-mode.

Copy link
Contributor Author

@LaurenceWarne LaurenceWarne Jul 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to use the appropriate function to match the emacs major-mode.

Cool, I've amended the commit to include this.

@akicho8
Copy link
Owner

akicho8 commented Jul 25, 2021

Thanks to this PR.
I know only Japanese language, so I was anxious that the translated English reading was read and understood.
I am glad to fix it to the English that everyone can understand.

Use defcustom for string-inflection-skip-backward-when-done instead of
defvar and create a custom group.  Improve the wording in some parts
of the README.
@LaurenceWarne LaurenceWarne force-pushed the defcustom-and-wording branch from 83d1402 to ecb58dd Compare July 25, 2021 08:13
@LaurenceWarne
Copy link
Contributor Author

Thanks to this PR.
I know only Japanese language, so I was anxious that the translated English reading was read and understood.
I am glad to fix it to the English that everyone can understand.

No problem, mostly the meaning comes across fine, only the wording is a little strange 🙂

@akicho8 akicho8 merged commit 76d8c0c into akicho8:master Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants