Skip to content

Comments

chore: Drop deprecated persistent-fsm after deprecation cycle#32058

Merged
johanandren merged 5 commits intoakka:mainfrom
johanandren:wip-drop-persistent-fsm
Sep 22, 2023
Merged

chore: Drop deprecated persistent-fsm after deprecation cycle#32058
johanandren merged 5 commits intoakka:mainfrom
johanandren:wip-drop-persistent-fsm

Conversation

@johanandren
Copy link
Contributor

Needs mention in migration guide once #32056 is merged

@johanandren johanandren added this to the 2.9.0-M1 milestone Aug 25, 2023
Copy link
Contributor

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, after migration guide

@johanandren johanandren force-pushed the wip-drop-persistent-fsm branch from 1d43677 to 381efe1 Compare August 28, 2023 07:21
@johanandren
Copy link
Contributor Author

I think i dropped too much here. I think we need to keep the adapters in typed persistence or else migrated apps will break.

@johanandren
Copy link
Contributor Author

Making a migrated system work means pulling back a lot of the FSM stuff in addition to that adapter though, classes for events, snapshot, serialization.

@patriknw patriknw removed this from the 2.9.0-M1 milestone Sep 5, 2023
@johanandren johanandren force-pushed the wip-drop-persistent-fsm branch from 381efe1 to fe3d890 Compare September 20, 2023 13:59
Copy link
Contributor

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, aside from...

@johanandren johanandren merged commit cc3d09a into akka:main Sep 22, 2023
@johanandren johanandren deleted the wip-drop-persistent-fsm branch September 22, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants