Conversation
leviramsey
commented
Sep 20, 2023
| result shouldBe a[TimeoutException] | ||
| result.getMessage should startWith("Ask timed out on") | ||
| // Message in the TimeoutException depends on the race between the actor stopping and | ||
| // the PromiseRef initializing... it's not really important for this test |
Contributor
Author
There was a problem hiding this comment.
Could also check that exactly one of the patterns (^Ask timed out on.*$ or ^Recipient.* had already terminated.$) matches, if we want to test that this only times out in one of two ways, but not sure on the value there.
Contributor
There was a problem hiding this comment.
Actually, the original purpose of this line is mock an actor dead, and expected both future failure and dead letters.
Therefore, the "ask timeout out" is an mistake on PR #32104.
Roiocam
reviewed
Sep 20, 2023
| case DeadLetter(Foo(s, _), _, recipient) => | ||
| s should ===("bar") | ||
|
|
||
| val classicRef = ActorRefAdapter.toClassic(ref) |
Contributor
There was a problem hiding this comment.
Great consolidate, thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The particular message in the
TimeoutExceptionwhen an actor being asked terminates depends on whether the termination happens before the ask pattern checks for termination.Per @Roiocam, the intent of the racy test is to exercise a scenario also set up (in a non-racy way) by another test, so this change now consolidates those cases.