Skip to content

Comments

bump: Agrona 1.22.0#32489

Merged
johanandren merged 2 commits intomainfrom
wip-agrona-pin
Aug 28, 2024
Merged

bump: Agrona 1.22.0#32489
johanandren merged 2 commits intomainfrom
wip-agrona-pin

Conversation

@johanandren
Copy link
Contributor

References #32488

Aeron 1.44.1 depends on a agrona range starting with 1.21.0 but up to 2.0, current agrona 1.23.0 has moved to target JDK 17 so we must stay on 1.22

@leviramsey
Copy link
Contributor

Note that Aeron 1.46.0 will require Agrona 1.23 or later, so no later Aeron until we drop JDK11 support.

@johanandren
Copy link
Contributor Author

I'll add a comment about both.

// https://github.com/real-logic/aeron/blob/1.x.y/build.gradle
val agronaVersion = "1.19.2"
// Note: 1.23+ is JDK 17 only so we cannot bump until we stop supporting JDK 11
val agronaVersion = "1.22.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking at Test/dependencyTree in akka-cluster

[info]   | +-io.aeron:aeron-client:1.44.1
[info]   | | +-io.aeron:aeron-annotations:1.44.1
[info]   | | +-org.agrona:agrona:1.23.0
[info]   | | +-org.agrona:agrona:[1.21.1,2.0) (evicted by: 1.23.0)

I wonder where that agrona 1.23.0 comes from?
Also, why did this start failing 5 days ago? https://github.com/akka/akka/actions/workflows/nightly-builds.yml

Copy link
Contributor Author

@johanandren johanandren Aug 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the range [1.21.1,2.0) means that we already were on 1.22 but we never noticed, once they released JDK 17+ 1.23 it bumped for us. Some sbt resolution rule where it wins because range incompatible with our direct dependency I had not seen before.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incompatible as: we depended on 1.19 but range on aeron said it needed 1.21 minimum.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, scary. dependencyTree is looking good in this branch

Copy link
Contributor

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johanandren johanandren merged commit 6a0c308 into main Aug 28, 2024
@johanandren johanandren deleted the wip-agrona-pin branch August 28, 2024 14:39
@johanandren johanandren added this to the 2.9.6 milestone Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants