Skip to content

Comments

bump: slf4j 2.0.16, logback 1.5.7#32497

Merged
sebastian-alfers merged 5 commits intoakka:mainfrom
sebastian-alfers:bump-slf4-logback
Sep 3, 2024
Merged

bump: slf4j 2.0.16, logback 1.5.7#32497
sebastian-alfers merged 5 commits intoakka:mainfrom
sebastian-alfers:bump-slf4-logback

Conversation

@sebastian-alfers
Copy link
Contributor

Reverts the reflection based workaround introduced in #31825.

@johanandren
Copy link
Contributor

There's some docs that need updating as well: https://doc.akka.io/docs/akka/current/typed/logging.html#slf4j-api-compatibility

@sebastian-alfers
Copy link
Contributor Author

There's some docs that need updating as well: https://doc.akka.io/docs/akka/current/typed/logging.html#slf4j-api-compatibility

Good point. I added a small correction to that part. But maybe we can even drop the entire "SLF4J API compatibility" section?

@sebastian-alfers sebastian-alfers marked this pull request as ready for review September 2, 2024 12:22
Co-authored-by: Johan Andrén <johan@markatta.com>
Copy link
Contributor

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also start a new migration page where we mention this dependency update.
https://github.com/akka/akka/tree/main/akka-docs/src/main/paradox/project


It is however not possible to mix a logger backend supporting one version with SLF4J API of other version, that will lead
It is not possible to mix a logger backend supporting one version with SLF4J API of older versions, that will lead
to no logging to output like this:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is below log message obsolete now? I don't think we want to encourage downgrading slf4j as is explained in below workaround.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, lets remove all the "working around this" docs.

Copy link
Contributor

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patriknw
Copy link
Contributor

patriknw commented Sep 4, 2024

Refs #32364

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants