fix: Check max frame size in inbound TCP framing#32791
Merged
johanandren merged 1 commit intomainfrom Aug 29, 2025
Merged
Conversation
johanandren
approved these changes
Aug 29, 2025
patriknw
commented
Aug 29, 2025
| override def parse(reader: ByteReader): ParseResult[EnvelopeBuffer] = { | ||
| val frameLength = reader.readIntLE() | ||
| if (frameLength > maxFrameLength) | ||
| throw new FramingException(s"Too long frame [$frameLength], max length is [$maxFrameLength]") |
Contributor
Author
There was a problem hiding this comment.
I'll verify one more thing before we include this in a release. Perhaps it's not great to fail the entire inbound stream in this case. Not sure how that error is handled. Might be better to discard, if possible.
Contributor
Author
There was a problem hiding this comment.
I have confirmed that it's ok to throw FramingException. It will close that connection, but it's possible to continue fine after that.
outbound connection to [akka://RemoteConnectionSpec-remote-0@localhost:51094], message stream] Upstream failed, cause: StreamTcpException: The connection closed with error: Connection reset
It's possible to trigger such FramingException in other ways, such as wrong magic, non-matching frame length and such, so we can handle this in the same way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.