Skip to content

fix: Don't send content length header for unary gRPC responses #2075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johanandren merged 2 commits into from
Aug 21, 2025
Merged

fix: Don't send content length header for unary gRPC responses #2075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86abd2a
fix: Don't send content length header for unary gRPC responses
johanandren Aug 20, 2025
68a3ce6
bump: Akka HTTP 10.7.2
johanandren Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion project/Dependencies.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ object Dependencies {
// https://doc.akka.io/libraries/akka-core/current/project/downstream-upgrade-strategy.html
val akka = "2.10.5"
val akkaBinary = VersionNumber(akka).numbers match { case Seq(major, minor, _*) => s"$major.$minor" }
val akkaHttp = "10.7.1"
val akkaHttp = "10.7.2"
val akkaHttpBinary = VersionNumber(akkaHttp).numbers match { case Seq(major, minor, _*) => s"$major.$minor" }

val grpc = "1.72.0" // checked synced by VersionSyncCheckPlugin
Expand Down
3 changes: 2 additions & 1 deletion runtime/src/main/scala/akka/grpc/internal/GrpcProtocolWeb.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ abstract class GrpcProtocolWebBase(subType: String) extends AbstractGrpcProtocol
HttpResponse(
status = StatusCodes.OK,
headers = headers,
entity = HttpEntity(contentType, encodeDataToFrameBytes(codec, data, trailer)),
entity =
HttpEntity.Strict(contentType, encodeDataToFrameBytes(codec, data, trailer), reportContentLength = false),
Copy link
Copy Markdown
Contributor

@patriknw patriknw Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no risk that this changes the behavior (for others) in undesired way and we should enable it via a config instead?

Copy link
Copy Markdown
Contributor Author

@johanandren johanandren Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was also worried about that, but James has assured me. The Content-Length header is redundant with HTTP/2 but can be included for backwards compatibility, the binary gRPC protocol however was always only HTTP/2, so unlikely that some client would assume HTTP/1.1 stuff.

protocol = HttpProtocols.`HTTP/1.1`)

private def encodeDataToFrameBytes(codec: Codec, data: ByteString, trailer: Trailer): ByteString = {
Expand Down
Loading