fix: Ensure Java servers are invoked on the specified execution context#2082
Merged
johanandren merged 1 commit intomainfrom Oct 28, 2025
Merged
fix: Ensure Java servers are invoked on the specified execution context#2082johanandren merged 1 commit intomainfrom
johanandren merged 1 commit intomainfrom
Conversation
johanandren
commented
Oct 20, 2025
Contributor
Author
There was a problem hiding this comment.
This and SingleParameterSink is unrelated boyscouting
johanandren
commented
Oct 20, 2025
| case "@method.grpcName": | ||
| response = @{method.unmarshal}(request.entity(), @method.deserializer.name, mat, reader) | ||
| .@{if(method.outputStreaming) { "thenApply" } else { "thenCompose" }}(e -> implementation.@{method.name}(e@{if(powerApis) { ", metadata" } else { "" }})) | ||
| .@{if(method.outputStreaming) { "thenApplyAsync" } else { "thenComposeAsync" }}(e -> implementation.@{method.name}(e@{if(powerApis) { ", metadata" } else { "" }}), mat.executionContext()) |
Contributor
Author
There was a problem hiding this comment.
We need to start off with one of the signatures that let's us enforce dispatcher, subsequent calls to thenApply will be on calling thread or this dispatcher.
That means calls will always lead to scheduling the invocation to the user service method impl, which means a bit more overhead, while before it could be invoked on the calling thread (which is safe here since already on the right dispatcher).
There seems to be no way around that, there is no way to say cs.useThisEc(ec) to make subsequent calls "inherit" it.
pvlugter
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.