Skip to content

Improve logging for Cluster.Bootstrap hostname matching diagnostics #3388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aaronontheweb merged 1 commit into from
Oct 27, 2025
Merged

Improve logging for Cluster.Bootstrap hostname matching diagnostics #3388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 32 additions & 5 deletions src/management/Akka.Management/Cluster/Bootstrap/SelfAwareJoinDecider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,12 @@ public bool CanJoinSelf(ServiceDiscovery.ResolvedTarget target, SeedNodesInforma

if (!info.ContactPoints.Any(t => MatchesSelf(t, self)))
{
Log.Warning("Self contact point [{0}] not found in targets {1}",
Log.Warning(
"Self contact point [{0}] (hostname: {1}, port: {2}) not found in targets [{3}]",
ContactPointString(self),
string.Join(", ", info.ContactPoints));
self.host,
self.port,
string.Join(", ", info.ContactPoints.Select(ContactPointString)));
}
return false;
}
Expand All @@ -62,14 +65,38 @@ public bool MatchesSelf(ServiceDiscovery.ResolvedTarget target, (string host, in
{
if (target.Port == null)
return HostMatches(contactPoint.host, target);
return HostMatches(contactPoint.host, target) && contactPoint.port == target.Port;

var hostMatches = HostMatches(contactPoint.host, target);
var portMatches = contactPoint.port == target.Port;
var result = hostMatches && portMatches;

if (Log.IsDebugEnabled && hostMatches && !portMatches)
{
Log.Debug(
"MatchesSelf: Hostname matched but port mismatch - self port={0}, target port={1}",
contactPoint.port, target.Port);
}

return result;
}

public bool HostMatches(string host, ServiceDiscovery.ResolvedTarget target)
{
var cleaned = _hostReplaceRegex.Replace(host, "");
return string.Equals(host, target.Host, StringComparison.OrdinalIgnoreCase) ||
(target.Address?.ToString() ?? "").Contains(cleaned);
var directMatch = string.Equals(host, target.Host, StringComparison.OrdinalIgnoreCase);
var addressString = target.Address?.ToString() ?? "";
var containsMatch = addressString.Contains(cleaned);
var result = directMatch || containsMatch;

if (Log.IsDebugEnabled)
{
Log.Debug(
"HostMatches comparison: self hostname='{0}', target hostname='{1}', target address='{2}', " +
"direct match={3}, contains match={4}, result={5}",
host, target.Host, addressString, directMatch, containsMatch, result);
}

return result;
}

public abstract Task<IJoinDecision> Decide(SeedNodesInformation info);
Expand Down
3 changes: 2 additions & 1 deletion src/management/Akka.Management/Dsl/AkkaManagement.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,8 @@ public Route[] Routes(Func<ManagementRouteProviderSettings, ManagementRouteProvi
var effectiveBindPort = Settings.Http.EffectiveBindPort;
var effectiveProviderSettings = transformSettings(ProviderSettings());

_log.Info("Binding Akka Management (HTTP) endpoint to: {0}:{1}", effectiveBindHostname, effectiveBindPort);
_log.Info("Binding Akka Management (HTTP) endpoint to: {0}:{1}, advertising as hostname: {2}",
effectiveBindHostname, effectiveBindPort, Settings.Http.Hostname);

var combinedRoutes = PrepareCombinedRoutes(effectiveProviderSettings);

Expand Down