Add failing tests proving heartbeat surrender bug (#3404)#3407
Merged
Aaronontheweb merged 5 commits intoakkadotnet:devfrom Mar 9, 2026
Merged
Conversation
…ing lease (cherry picked from commit 0cf2b4e)
Member
Author
|
Integrated Gregorius' original Azure heartbeat-retry fix into this branch and extended it to Kubernetes for parity.\n\nIncluded with attribution via cherry-pick:\n- 0cf2b4e ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LeaseActorspecs.Status.Failurecurrently causes immediate lease surrender instead of retrying within the TTL safety window.What these tests assert
Grantedtofalse,leaseLostCallback, orCurrent behavior (bug)
Both implementations immediately surrender lease on
Status.Failurewhile inGranted:LeaseActor.csinGrantedhandler (Status.Failurebranch)LeaseActor.csinGrantedhandler (Status.Failurebranch)Observed failure in both test suites:
Why this PR
Previous fix attempts went straight to implementation. This PR is repro-only to build a deterministic, reviewable proof that the bug is real in both providers before proposing fixes.
Fixes #3404
Closes #3405