Override and pass in additional grafana agent config keys#161
Merged
akoutmos merged 1 commit intoakoutmos:masterfrom Sep 13, 2022
Merged
Override and pass in additional grafana agent config keys#161akoutmos merged 1 commit intoakoutmos:masterfrom
akoutmos merged 1 commit intoakoutmos:masterfrom
Conversation
This permits template_file to be overridden, and for additional variables to be passed through to the template file.
Contributor
Author
|
@akoutmos what can I do to help get this merged? |
akoutmos
approved these changes
Sep 13, 2022
Owner
|
Sorry about that @patmaddox. Totally forgot about this one! Looks good to me. Will merge once CI passes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#159 was missing a commit that we had on a different branch when testing. Sorry for not being more careful there.
This permits template_file to be overridden, and for additional variables to be passed through to the template file.
Change description
The config currently passes an explicit list of keys to grafana agent config. Any keys not in that list will not get sent.
This change allows us to send additional grafana agent config keys that will be passed through to the template file.
It's necessary to enable the functionality of #159 - without it, a
template_fileconfig won't get passed to the grafana agent config.Checklist
We have deployed this branch to production and confirmed that it fixes the problem described above.