new: adds support for phoenix 1.7#192
Merged
akoutmos merged 1 commit intoakoutmos:masterfrom Mar 31, 2023
Merged
Conversation
|
This is absolutely necessary for those who want to upgrade their installation to phoenix 1.7. |
|
bump |
Contributor
|
bump from me too - what's the hold-up? |
tmartin8080
approved these changes
Mar 31, 2023
Collaborator
tmartin8080
left a comment
There was a problem hiding this comment.
Thanks for bumping this:
plug_cowboy2.6 adds support for websockets- tested the upgrades in a Phoenix 1.6 setup and didn't find any issues
tmartin8080
reviewed
Mar 31, 2023
| {:telemetry_metrics, "~> 0.6"}, | ||
| {:telemetry_metrics_prometheus_core, "~> 1.0"}, | ||
| {:plug_cowboy, "~> 2.5.1"}, | ||
| {:plug_cowboy, "~> 2.6"}, |
Collaborator
There was a problem hiding this comment.
Noting that we could use or to be safe:
{:plug_cowboy, "~> 2.5.1 or ~> 2.6"},
Owner
Sorry for the delay. Been dealing with some health emergencies lately. Will try and merge #184 in this weekend and will cut a release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #191
Change description
Bumps plug_cowboy to support Phoenix 1.7
What problem does this solve?
Issue number: #191
Example usage
Additional details and screenshots
Checklist
Cant verify as some unit tests also busted on
mastertoo: