[revert] remove Statusbar marginTop for navTransparent#3493
Conversation
Owner
|
I can't merge this ticket because it brakes existing apps (on iOS). Probably you can add check for iOS/Android and set/not set height depends from ios.. |
Contributor
Author
@aksonov It only affect to android |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason
Status bar can be overlay to screen(app will draw under the status bar), It is not odd behavior..
Transplucent status bar is default in iOS(cli, expo) and Android(expo)
But not default option on Android(cli), it just can be set by translucent of 'StatusBar'
If user want to status bar overlay to screen, they must use 'SafeAreaView' but this working only in iOS, because that concept doesn't exist on Android.
for this reason, not margin top to navigation in RNRF but padding top to screen(or wrapping routes with OverlayStatusBarView) by user self
please see the example code