Helm chart should allow conditionally creating the service accounts

[mycodeself]

Pre-submission checklist

• I have searched existing issues and confirmed this is not a duplicate.
• I understand that submitting a feature request does not guarantee it will be implemented.

Proposed Feature

The helm chart should support the standard pattern used by most of other helm charts to conditionally disable the creation of the services accounts, specially the one for the controller which might require the role ARN annotation and as a user I would like to create it dynamically to avoid hardcoding a role ARN in the values.yaml file.

controller:
  serviceAccount:
    create: false           # when false, chart does NOT render the SA manifest

This requires a simple change in the service account template here

{{- if and .Values.controller.enabled .Values.controller.serviceAccount.create }}
apiVersion: v1
kind: ServiceAccount
metadata:

I would be open contributing to apply this changes.

Motivation and Use Case

In IRSA setups the ServiceAccount could be created outside the helm chart in a dynamic way with the correct eks.amazonaws.com/role-arn annotation without having to actually hardcode the role ARN. The Helm chart should only consume that SA, not own it.

Alternatives Considered

No response

[mycodeself]

Hello @krancour

I'm wondering if you will accept a PR fixing this even if has some of the considered as blocking labels, since I think this change is small enough to maybe qualify as an exception, what do you think?

thanks!

[krancour]

I would like to hold off on this. We're in the midst of some significant changes to the chart in support of some internal priorities. I'd be more open to considering this after that all settles down.