Skip to content

Change default lun from lun1 to lun0#1667

Merged
JimMadge merged 5 commits into
alan-turing-institute:developfrom
craddm:change-default-lun
Nov 13, 2023
Merged

Change default lun from lun1 to lun0#1667
JimMadge merged 5 commits into
alan-turing-institute:developfrom
craddm:change-default-lun

Conversation

@craddm

@craddm craddm commented Nov 10, 2023

Copy link
Copy Markdown
Contributor

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).
  • You have marked this pull request as a draft and added '[WIP]' to the title if needed (if you're not yet ready to merge).
  • You have formatted your code using appropriate automated tools (for example ./tests/AutoFormat_Powershell.ps1 -TargetPath <path to file or directory> for Powershell).

⤴️ Summary

Replaces hard-coded references to lun1 with references to lun0, and changes code so disks added to VMs start from LUN0 instead LUN1. Note that this PR also contains the same devcontainer changes as #1662

🌂 Related issues

Closes #911

🔬 Tests

Tested deployment of resources affected by the change.

@JimMadge
JimMadge merged commit 099857e into alan-turing-institute:develop Nov 13, 2023
@craddm
craddm deleted the change-default-lun branch November 15, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Start disk deployment from LUN0

2 participants