Change default lun from lun1 to lun0#1667
Merged
JimMadge merged 5 commits intoNov 13, 2023
Merged
Conversation
craddm
requested review from
JimMadge,
jemrobinson and
martintoreilly
as code owners
November 10, 2023 15:20
JimMadge
approved these changes
Nov 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ Checklist
Enable foobar integrationrather than515 foobar).develop.'[WIP]'to the title if needed (if you're not yet ready to merge)../tests/AutoFormat_Powershell.ps1 -TargetPath <path to file or directory>for Powershell).Replaces hard-coded references to
lun1with references tolun0, and changes code so disks added to VMs start fromLUN0insteadLUN1. Note that this PR also contains the same devcontainer changes as #1662🌂 Related issues
Closes #911
🔬 Tests
Tested deployment of resources affected by the change.