Update software on guacamole server#1741
Merged
Merged
Conversation
craddm
marked this pull request as ready for review
February 13, 2024 15:44
craddm
requested review from
JimMadge,
jemrobinson and
martintoreilly
as code owners
February 13, 2024 15:44
JimMadge
approved these changes
Feb 15, 2024
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ Checklist
Enable foobar integrationrather than515 foobar).develop.'[WIP]'to the title if needed (if you're not yet ready to merge)../tests/AutoFormat_Powershell.ps1 -TargetPath <path to file or directory>for Powershell).Updates the versions of Guacamole, nginx, and Postgres used on the Guacamole remote desktop server.
In addition, sometimes the Postgres database did not finish initializing before Docker launched Guacamole, and thus Guacamole sometimes did not function. This PR adds a health check to the
docker-compose.yamlto make Docker wait until the Postgres database is fully responsive. This necessitated migrating from Docker Compose v1 -docker-compose- to Docker Compose v2 -docker compose. Compose v1 is no longer supported, and the necessary syntax to perform the health check was not supported.🌂 Related issues
Relates to #1738 but does not close it, as this PR only focuses on the Guacamole server.
🔬 Tests
Deployed a Guacamole server within an SRE and checked that it functioned correctly.