Pin Click to version 8.1.8#2440
Merged
jemrobinson merged 1 commit intoJun 27, 2025
Merged
Conversation
DSH currently has Typer fixed to version 0.15.2. Typer has Click as a dependency, but Typer 0.15.2 doesn't fix the Click version. Installing Typer 0.15.2 therefore, by default, results in Click 8.2.0 being installed (the latest version of Click as of now). Unfortunately Typer 0.15.2 isn't compatible with Click 8.2.0. This change therefore fixes Click to 8.1.8 in order to retain compatibility. Without this fix, calling "dsh --help" on a clean install results in an error. Fixes alan-turing-institute#2439
5 tasks
Member
|
@cptanalatriste can you check this issue and fix? |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ Checklist
Enable foobar integrationrather than515 foobar).develop.🚦 Depends on
DSH currently has Typer pinned to version 0.15.2. Typer has Click as a dependency, but Typer 0.15.2 doesn't pin the Click version. Installing Typer 0.15.2 therefore, by default, results in Click 8.2.0 being installed (the latest version of Click as of now).
Unfortunately Typer 0.15.2 isn't compatible with Click 8.2.0. This change therefore pins Click to 8.1.8 in order to retain compatibility. Without this fix, calling "dsh --help" on a clean install results in an error.
Note that an alternative solution would be to upgrade the pinned version of Typer to 0.15.4, see Issue #1215 in the Typer repository. I didn't go down this route because I thought this would probably need more robust testing. But it's probably the better option.
🌂 Related issues
Closes #2439
🔬 Tests
I've not tested this change. I've only performed a preliminary test by installing this version of Click manually in a virtual environment: