fix(core): lowercase generated physical names #1257
+3
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
🚀 Website Preview DeployedYour website preview is ready! Preview URL: https://eaa1d5e6-alchemy-website.alchemy-run.workers.dev This preview was built from commit 34379a6 🤖 This comment will be updated automatically when you push new commits to this PR. |
sam-goodwin
reviewed
Dec 11, 2025
alchemy/src/cloudflare/website.ts
Outdated
| ) { | ||
| const { | ||
| name = Scope.current.createPhysicalName(id), | ||
| name = Scope.current.createPhysicalName(id).toLowerCase(), |
Collaborator
There was a problem hiding this comment.
Any reason not to do it for all physical names?
Collaborator
Author
There was a problem hiding this comment.
No, good catch - I was being a little too conservative. Will update now
Collaborator
There was a problem hiding this comment.
On second thought, I really hope this doesn't cause issues for people? Should it be up to each resource to lowercase it, or do we bit the bullet now and apply this blanket across all resources?
Which resources could it cause unnecessary replacements on?
john-royal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1251 and addresses a follow-up comment in #1135.
The problem was that while we were lowercasing the default worker generated name for the
Workerresource, we weren't doing that for theWebsiteresource, which affected generated wrangler.jsonc files.