Skip to content

feat: upgrade to our latest version of pytezos #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Conversation

Psycojoker
Copy link
Collaborator

@Psycojoker Psycojoker commented Aug 14, 2024

ALEPH-207

@Psycojoker Psycojoker force-pushed the lp-pytezos branch 2 times, most recently from ac5871d to e31377d Compare January 8, 2025 13:27
@Psycojoker Psycojoker marked this pull request as ready for review January 8, 2025 13:38
@github-actions github-actions bot added the RED This PR is complex and may require more time to review. label Jan 8, 2025
Copy link

github-actions bot commented Jan 8, 2025

Summary:
The PR involves significant changes to the GitHub Actions workflows and the pyproject.toml file, which could potentially affect the build and testing processes. These changes include updating Python versions, modifying dependency versions, and adjusting installation commands.

Details:

  • Workflow Changes:

    • The build-wheels.yml workflow now uses Python 3.12 instead of 3.11.
    • The pytest.yml workflow now includes Python 3.12 and supports both Ubuntu 22.04 and Ubuntu 24.04.
    • Updates to the installation commands in both workflows, including upgrading setuptools and installing additional dependencies like libsodium-dev.
  • Dependency Changes:

    • The pyproject.toml file updates the optional-dependencies.tezos section to use aleph-pytezos==3.13.4, which could affect compatibility with other packages or functionalities.
  • Code Changes:

    • The tests/unit/test_chain_tezos.py file includes changes to assertion lengths, which could indicate potential issues with cryptographic operations or data integrity.

Impact:
These changes could have potential risks, especially if they affect the build and testing processes, which are crucial for ensuring the reliability of the package. The updated Python versions and dependency versions could lead to unforeseen issues, and the changes to the installation commands might impact the environment setup for contributors.

Highlighted Changes:

  • Workflow Changes:
    -         python-version: 3.11
    +         python-version: 3.12
    • Dependency Changes:
    -         "aleph-pytezos==0.1.1"
    +         "aleph-pytezos==3.13.4"
    • Code Changes:
    -         assert len(signed["signature"]) == 188
    +         assert len(signed["signature"]) == 187

Conclusion:
This PR requires a thorough review to ensure that the changes do not introduce bugs or break compatibility with existing workflows and dependencies. The complexity of these changes warrants a detailed examination to understand the potential impact on the codebase and the review process.

@Psycojoker Psycojoker requested review from hoh and philogicae January 8, 2025 17:56
Copy link
Member

@philogicae philogicae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Psycojoker Psycojoker merged commit 5fd68b4 into main Jan 8, 2025
23 checks passed
@Psycojoker Psycojoker deleted the lp-pytezos branch January 8, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RED This PR is complex and may require more time to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants