hoh simplify config #395
Merged
hoh simplify config #395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of making the defaults developer friendly (assuming the developer runs all these services on localhost), assume that users use docker-compose by default.
|
Cool! I had this in the back of my mind for a while. Just fix the unit tests config, tests run outside of Docker so you'll need to use 127.0.0.1 as host address for Postgres and Redis. |
odesenfans
pushed a commit
that referenced
this pull request
Apr 21, 2023
Instead of making the defaults developer friendly (assuming the developer runs all these services on localhost), assume that users use docker-compose by default.
odesenfans
pushed a commit
that referenced
this pull request
Apr 24, 2023
Instead of making the defaults developer friendly (assuming the developer runs all these services on localhost), assume that users use docker-compose by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.