Fix: missing parameter for broadcast_and_process #483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: The secure upload functionality does not provide the `message_dict` argument to the `broadcast_and_process_message` utility function. This causes a 500 error. Solution: Make the parameter default to None. Document `broadcast_and_process_message`.
Problem: `broadcast_and_process_message` fails when the `message_dict` argument is set to None because the `time` field is then specified as a datetime object instead of a float. Solution: add a formatting function that converts the `time` key to a float.
odesenfans
force-pushed
the
od-fix-secure-upload
branch
from
b5220a9 to
0c5ea87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: The secure upload functionality does not provide the
message_dictargument to thebroadcast_and_process_messageutility function. This causes a 500 error.Solution: Make the parameter default to None. Document
broadcast_and_process_message.