Skip to content

fix(api): correctly name types paramters of /posts.json #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

Psycojoker
Copy link
Collaborator

@Psycojoker Psycojoker commented Nov 29, 2024

The types parameters for queries on /posts.json was not taken into account because it was badly named.

Related Clickup or Jira tickets : ALEPH-301

Self proofreading checklist

  • Is my code clear enough and well documented
  • Are my files well typed
  • New translations have been added or updated if new strings have been introduced in the frontend
  • Database migrations file are included
  • Are there enough tests
  • Documentation has been included (for new feature)

Changes

Just correctly name it.

How to test

Simply do a query on posts.json with the types[]=... query parameters like so:

curl 'http://localhost:4024/api/v0/posts.json?types[]=corechan-operation' | python -m json.tool | grep '"type":'

Print screen / video

image

@Psycojoker Psycojoker requested a review from nesitor November 29, 2024 03:32
@nesitor nesitor merged commit faeefc2 into main Dec 2, 2024
4 checks passed
@nesitor nesitor deleted the aleph-301-solve-message-filtering-by-type branch December 2, 2024 09:03
aliel added a commit that referenced this pull request Jan 14, 2025
nesitor pushed a commit that referenced this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants