Skip to content

config: Add a timeout option for the ethereum client #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

aliel
Copy link
Member

@aliel aliel commented Dec 3, 2024

This PR solves a timeout problem on some Ethereum RPCs, as the default timeout is set to 30s by the web3 client,

this PR allows the node operator to configure the timeout according to the rpc and network parameters.

Self proofreading checklist

  • Is my code clear enough and well documented
  • Are my files well typed
  • New translations have been added or updated if new strings have been introduced in the frontend
  • Database migrations file are included
  • Are there enough tests
  • Documentation has been included (for new feature)

@aliel aliel force-pushed the aliel-add-eth-timeout-config branch from c3d1403 to 9e093be Compare December 3, 2024 20:55
@aliel aliel requested review from hoh and nesitor December 3, 2024 20:55
@aliel aliel force-pushed the aliel-add-eth-timeout-config branch from 9e093be to 9a5d1db Compare December 3, 2024 20:56
@aliel aliel force-pushed the aliel-add-eth-timeout-config branch from 9a5d1db to 29735b3 Compare December 16, 2024 11:57
@nesitor nesitor marked this pull request as ready for review December 16, 2024 12:01
@aliel aliel merged commit 7543b6b into main Dec 16, 2024
4 checks passed
@nesitor nesitor deleted the aliel-add-eth-timeout-config branch December 16, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants