Estimate costs update #703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: test_cost_service.py * fix: format_cost using quantize instead of ceil * fix: cost unit test * fix: format quantize use ROUND_FLOOR instead of ROUND_CEILING * Fix: lint issue * Fix: lint issue * Fix mypy issue with TypeAlias * fix: cost service * fix: get_get_total_and_detailed_costs_from_db rename into get_total_and_detailed_costs * fix: test process instances * fix: add get_total_and_detailed_costs_from_db import * fix: test_balances * fix: from_aggregate method of ProductPricing * fix: from_aggregate method of ProductPricing * fix: test_storage * fix: storage file * fix: test_get_total_balance * fix: test_process_confidential_vm missing aggregate in db fixture * Fixed `test_get_total_cost_for_address` test * Fixed `test_compare_account_cost_with_cost_payg_funct` test and `test_program_with_subscriptions` test * fix: fixture_product_prices_aggregate_in_db was missing * fix: _calculate_storage_costs logic * fix: mypy issue --------- Co-authored-by: Andres D. Molins <[email protected]>
* fix: test_cost_service.py * fix: format_cost using quantize instead of ceil * fix: cost unit test * fix: format quantize use ROUND_FLOOR instead of ROUND_CEILING * Fix: lint issue * Fix: lint issue * Fix mypy issue with TypeAlias * fix: cost service * fix: get_get_total_and_detailed_costs_from_db rename into get_total_and_detailed_costs * fix: test process instances * fix: add get_total_and_detailed_costs_from_db import * fix: test_balances * fix: from_aggregate method of ProductPricing * fix: from_aggregate method of ProductPricing * fix: test_storage * fix: storage file * fix: test_get_total_balance * fix: test_process_confidential_vm missing aggregate in db fixture * Fixed `test_get_total_cost_for_address` test * Fixed `test_compare_account_cost_with_cost_payg_funct` test and `test_program_with_subscriptions` test * fix: fixture_product_prices_aggregate_in_db was missing * fix: _calculate_storage_costs logic * fix: mypy issue --------- Co-authored-by: Andres D. Molins <[email protected]>
1yam
reviewed
Feb 17, 2025
1yam
reviewed
Feb 17, 2025
nesitor
reviewed
Feb 17, 2025
nesitor
force-pushed
the
angel-estimate_costs_update
branch
from
64b4304 to
26b2266
Compare
nesitor
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self proofreading checklist
Changes
The price estimation endpoint now uses a different Message schema, less restrictive and accepting
estimated_size_mibprops passed from the client to calculate costs without uploading files up front.There is also a tiny refactor on the cost service, and a performance improvement on storage controller checking the account balance before uploading the volume