Skip to content

Feat: Support estimated_size_mib in program content schema for cost estimation endpoint #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 20, 2025

Conversation

amalcaraz
Copy link
Collaborator

@amalcaraz amalcaraz commented Mar 3, 2025

Self proofreading checklist

  • Is my code clear enough and well documented
  • Are my files well typed
  • New translations have been added or updated if new strings have been introduced in the frontend
  • Database migrations file are included
  • Are there enough tests
  • Documentation has been included (for new feature)

Changes

There are three volumes (runtime, code, data) directly related to the program message that needs to support the estimated_size_mib auxiliary field to be used only for cost estimation before sending the message to the network. It will be used from CLI and frontend clients.

@amalcaraz amalcaraz requested review from Psycojoker and nesitor March 3, 2025 17:20
@amalcaraz amalcaraz self-assigned this Mar 3, 2025
@amalcaraz amalcaraz marked this pull request as ready for review March 3, 2025 17:25
nesitor
nesitor previously approved these changes Mar 17, 2025
@amalcaraz amalcaraz force-pushed the angel-estimated_size_mib_program_code_volume branch from 56e36cc to e0b5b40 Compare March 20, 2025 16:41
@amalcaraz amalcaraz force-pushed the angel-estimated_size_mib_program_code_volume branch from e0b5b40 to b574bb3 Compare March 20, 2025 16:44
@amalcaraz amalcaraz requested a review from nesitor March 20, 2025 16:45
nesitor
nesitor previously approved these changes Mar 20, 2025
nesitor
nesitor previously approved these changes Mar 20, 2025
@nesitor nesitor merged commit 89ed12a into main Mar 20, 2025
5 checks passed
@nesitor nesitor deleted the angel-estimated_size_mib_program_code_volume branch March 20, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants