Preload All Scripts

[shadowtime2000]

Should resolve #7.

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/postui/alephjs-hello-world/obldp1oi8
✅ Preview: https://alephjs-hello-world-git-preload-files.postui.vercel.app

[ije]

• thanks, but consider the createHtml is a help function, please add the preload scripts in project.ts
• to keep code style, please use vscode default formater: always use ' for plain string and no ; as line end

[ije]

in fact all the preload-able scripts will pre-import in main.js(please check it in chrome) and main.js is preloaded, i am wondering maybe no preload scripts needed (should test it)

[ije]

and the preload script should be <link rel="modulepreload" src="..." /> since it's an esm script

[shadowtime2000]

in fact all the preload-able scripts will pre-import in main.js(please check it in chrome) and main.js is preloaded, i am wonder maybe no preload scripts needed (should test it)

@ije I think you are still going to need to preload those others scripts. Check this snip from the Google Lighthouse:

[ije]

i see, thanks, do you have a spare time to check the project.ts(it's a bit large)? the preload scripts shoud be added in here not html.ts, or i will finish it later.

[ije]

add preload scripts with createHtml function:

createHtml({
    ...
    scripts: [
        { src: '...', type: 'module', preload: true },
        ...
    ],
    ...
})

[shadowtime2000]

I will take a look at it.

[ije]

cool!

[shadowtime2000]

@ije I moved the changes to project.ts.

[ije]

@shadowtime2000 great!! i would create a function like:

function getPreloadScripts(baseUrl: string) {
    const scripts = [
         '-/deno.land/x/aleph/aleph.js',
        '-/deno.land/x/aleph/context.js',
        '-/deno.land/x/aleph/error.js',
        '-/deno.land/x/aleph/events.js',
        '-/deno.land/x/aleph/routing.js,',
        '-/deno.land/x/aleph/util.js'
    ]
    return scripts.map(src => ({ src: `${baseUrl}${src}`, type: 'module', preload: true }))
}

then inject it to all the createHtml calls:

createHtml({
    ...
    scripts: [
        ...
        ...getPreloadScripts(baseUrl),
        ...
    ],
    ...
})

then i will marge this request, thanks

[shadowtime2000]

@ije Done.

[ije]

LGTM; thanks