Repository navigation
fix(kopiur): retain snapshots on CR deletion during the pilot - #1559
Merged
Merged
Conversation
0.7.5 predates upstream's mass-deletion protection (kopiur#265): CR deletion, including a Flux prune, cascades into per-snapshot delete jobs that purge the repository. Retain disables repo-side GFS pruning, which is acceptable at pilot scale; revisit on the first release containing #265. Also records the failure mode in the storage doc's quirks section.
konflate — summaryNote +0 added · 1 changed · −0 removed — 1 resource · 1 app konflate · rendered |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.7.5 has no cascade guard — deleting the
SnapshotPolicy/SnapshotSchedule(a Flux prune counts) under the defaultdeletionPolicy: Deletemass-deletes repo snapshots via one Job each (community incident: 600–700 pods). Upstream fix home-operations/kopiur#265 merged the day after 0.7.5 was tagged and is unreleased.Sets
defaultDeletionPolicy: Retainon the pilot policy as an explicitly pilot-term guard: retention still prunes CRs but kopia snapshots accumulate; irrelevant at Bazarr scale, revisit at the first release containing #265 (tracked in the storage doc quirks section, updated here too).Validation: kustomize + oxfmt clean. Note: existing
SnapshotCRs keep their stamped policy — the already-taken manual snapshot needs a one-off patch, proposed separately.