Skip to content

change hardcode index name for using from env vars {{ .Indices.Visibility }} #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2023
Merged

change hardcode index name for using from env vars {{ .Indices.Visibility }} #371

merged 1 commit into from
Jun 7, 2023

Conversation

@DodgeCamaro
Copy link
Contributor

@DodgeCamaro DodgeCamaro commented May 29, 2023

When I try to change the index name, I've got an error on the update visibility index, from this step

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

alexandrevilain
alexandrevilain approved these changes Jun 7, 2023
View reviewed changes
Copy link
Owner

@alexandrevilain alexandrevilain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!
Sorry for the delay I though I already approved your PR!

@alexandrevilain alexandrevilain merged commit dc103a6 into alexandrevilain:main Jun 7, 2023
@DodgeCamaro DodgeCamaro deleted the update_elasticsearch_advanced_visibility_scripts branch June 8, 2023 13:47
@DodgeCamaro
Copy link
Contributor Author

DodgeCamaro commented Jun 13, 2023 •
edited
Loading

Due this file, for .Indices.Visibility need to use this index_patterns - temporal_visibility_v1*

Example for fixing this issue
sed 's/temporal_visibility_v1./{{ .Indices.Visibility }}/g' index_template_v7.json

P.S I've created PR for fix it
#383

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexandrevilain alexandrevilain alexandrevilain approved these changes

Assignees

No one assigned

Labels

bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DodgeCamaro @alexandrevilain @dmytro-orlenko