Skip to content

Conversation

@ujala-singh
Copy link
Contributor

@ujala-singh ujala-singh commented Sep 1, 2025

Implements 957

Summary

  • The GetPublicClientAddress method was always returning the frontend service address regardless of whether internal frontend was enabled.
  • This caused authentication issues for internal operations like creating the default namespace when auth was configured on the public frontend.

Validation

2025-09-01T06:55:20Z	INFO	Starting reconciliation	{"controller": "temporalnamespace", "controllerGroup": "temporal.io", "controllerKind": "TemporalNamespace", "TemporalNamespace": {"name":"default","namespace":"temporal"}, "namespace": "temporal", "name": "default", "reconcileID": "38d32796-6ead-41a1-adb0-e60f629eb8dd"}
2025-09-01T06:55:20Z	DEBUG	Connecting to temporal cluster	{"controller": "temporalnamespace", "controllerGroup": "temporal.io", "controllerKind": "TemporalNamespace", "TemporalNamespace": {"name":"default","namespace":"temporal"}, "namespace": "temporal", "name": "default", "reconcileID": "38d32796-6ead-41a1-adb0-e60f629eb8dd", "address": "temporal-cluster-internal-frontend-headless.temporal:7236"}
2025-09-01T06:55:20Z	INFO	Successfully reconciled namespace	{"controller": "temporalnamespace", "controllerGroup": "temporal.io", "controllerKind": "TemporalNamespace", "TemporalNamespace": {"name":"default","namespace":"temporal"}, "namespace": "temporal", "name": "default", "reconcileID": "38d32796-6ead-41a1-adb0-e60f629eb8dd", "namespace": "default"}

@alexandrevilain
Copy link
Owner

Thanks @ujala-singh !

Looks like it breaks mTLS e2e tests :)

@sonarqubecloud
Copy link

@ujala-singh
Copy link
Contributor Author

@alexandrevilain I have fixed it, it can use frontend only if TLS is enabled. Reference

I have updated the code accordingly as it will use frontend only if mTLS is enabled.

@nishantmunjal7
Copy link

@alexandrevilain are we good with this, can we merge ?

@alexandrevilain alexandrevilain merged commit e5d2368 into alexandrevilain:main Sep 21, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants