Upgrade to rust-url 1.0 #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm I'd prefer to hold off on bumping the major version just yet, I've got a rewrite queued up already for this and ideally that'd land at the same time |
|
Perhaps this could add the larger version range for now? |
|
Updated the PR and filed #104. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
Urlis (indirectly) part of the public API, I think this is a breaking change.It would be possible to depend on
url = ">= 0.5, < 2.0"(so that this wouldn’t be a breaking change) ifas_stris reverted toto_string, but that would leave an unnecessaryStringallocation.test_proxyfails for me locally with "Timeout was reached", but it also does on master.