Replace custom ExitStatus with std::process::ExitStatus using a hack #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The motivation for doing this is to make API compatible and composable with std::process::Command. For example, this will allow to implement extension of Command::wait_with_output accepting a timeout. I will probably burn in hell for this hack, but...
Owner
|
Thanks for the PR! Unfortunately right now I'm not comfortable relying on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation for doing this is to make API compatible and composable with
std::process::Command. For example, this will allow to implement extension ofCommand::wait_with_outputaccepting a timeout.I will probably burn in hell for this hack, but…
@alexcrichton What do you think, is such a hack acceptable for this crate?